react-native-track-player icon indicating copy to clipboard operation
react-native-track-player copied to clipboard

[Android] Breaking changes proposals for future major versions (3.0-4.0)

Open mpivchev opened this issue 3 years ago • 0 comments

This includes proposals for both this library and the Android audio library we use under the hood: KotlinAudio.

This list will be updated over time so nothing is concrete.

  • Rename QueuedAudioPlayer to PlaylistAudioPlayer. Stop using the term of queue and replace it with playlist in documentation and function/class names. Note: The term playlist is used and understandable by every person. It relates better to an audio player. Note 2: iOS side must also be updated for this.

  • Rename the position property in BaseAudioPlayer to currentPosition Note: More descriptive.

  • LocalBroadcastManager in MusicService has been deprecated. Replace it with another observable pattern.

mpivchev avatar Aug 09 '22 16:08 mpivchev

I have on more:

  • Have the audio players automatically handle loss of audio focus - there's a PR for Android already https://github.com/doublesymmetry/KotlinAudio/pull/12 - iOS would have to be updated too

dcvz avatar Aug 11 '22 09:08 dcvz

I think this one should be considered too

https://github.com/doublesymmetry/react-native-track-player/issues/1293

Effectively when you remove or add a track to/from the middle of the queue it causes a cascading change of all of the indexes for tracks coming after the insertion point. Technically this the way we have things defined now we should fire an event for the updated position.

jspizziri avatar Aug 11 '22 09:08 jspizziri

@puckey I think your work on Queue's should fall into this category.

jspizziri avatar Sep 14 '22 15:09 jspizziri

We should move stoppingAppPausesPlayback and compactCapabilities into the new android object on the MetadataOptions object (they're android specific config options).

jspizziri avatar Sep 14 '22 16:09 jspizziri