project-system icon indicating copy to clipboard operation
project-system copied to clipboard

Validate C# DefineConstants input

Open adamint opened this issue 11 months ago • 4 comments

As can be seen in this bug, you can add arbitrary semicolons in the DefineConstants control and these will be saved. This PR

  1. Adds tests for KeyValuePairListEncoding
  2. Allows for different separators
  3. Since the CPS controls hands the property interceptor a comma-separated list of values, but each individual value may itself contain a semicolon-separated list of constants, the property interceptor is changed to first convert the comma-separated list to a semicolon-separated list, then parse it again and trim semicolons from each value
Microsoft Reviewers: Open in CodeFlow

adamint avatar Dec 05 '24 08:12 adamint