maui icon indicating copy to clipboard operation
maui copied to clipboard

Implement Keyboard on SearchBarHandler

Open jsuarezruiz opened this issue 3 years ago • 1 comments

Description of Change

Implement Keyboard on SearchBarHandler.

fix-9594

Issues Fixed

Fixes #9594

jsuarezruiz avatar Sep 01 '22 14:09 jsuarezruiz

Changed target from net6.0 to main.

jsuarezruiz avatar Nov 22 '22 16:11 jsuarezruiz

I just tested and unfortunately, this doesn't fix the issue referenced :/ The keyboard continues to switch immediately back from numeric to alphabetic

I am curious about your approach here, though, as the issue you're working on here is related to the issue I'm working on in #11981

On Android?. Let me review it and take a quick look to the Japanese issue. This one was target to net6.0 and retarget to main now. Maybe something has changed in between.

jsuarezruiz avatar Dec 09 '22 16:12 jsuarezruiz

Added several Device tests validating all the keyboards on the SearchBar.

image

jsuarezruiz avatar Dec 14 '22 15:12 jsuarezruiz

Was this already resolved by #11981?

samhouts avatar Mar 03 '23 16:03 samhouts

@jsuarezruiz lets close it or land it. We have too many PRs.

mandel-macaque avatar Mar 07 '23 20:03 mandel-macaque

Was this already resolved by #11981?

This PR maps the Keyboard property to allow setting the numeric keypad for example. The other PR is a nice fix that prevents flickering on keyboard hints etc. Related but not the same.

jsuarezruiz avatar Mar 09 '23 15:03 jsuarezruiz

@jsuarezruiz lets close it or land it. We have too many PRs.

I agree, let me add more reviewers and push forward.

jsuarezruiz avatar Mar 09 '23 15:03 jsuarezruiz

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

github-actions[bot] avatar Mar 09 '23 15:03 github-actions[bot]

looks great on iOS and iPadOS too

rachelkang avatar Mar 16 '23 20:03 rachelkang