maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Fix [Android] CollectionView EmptyView SelectionMode=Single on Android

Open yurkinh opened this issue 3 years ago • 8 comments

Description of Change

If an empty view is used in a collection view with a single selection mode and there is no Item in the list on startup the app crashes on Android. Works fine on ios/Windows.

Fixes #9060

yurkinh avatar Aug 05 '22 13:08 yurkinh

Hey there @yurkinh! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Aug 05 '22 13:08 ghost

Hey there @yurkinh! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Aug 05 '22 13:08 ghost

/azp run

jfversluis avatar Aug 05 '22 13:08 jfversluis

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Aug 05 '22 13:08 azure-pipelines[bot]

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Aug 08 '22 09:08 azure-pipelines[bot]

We cold just check on line 16 and return there if it's null, so no other code will run if there's no adapter

rmarinho avatar Aug 08 '22 12:08 rmarinho

/azp run

rmarinho avatar Aug 10 '22 11:08 rmarinho

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Aug 10 '22 11:08 azure-pipelines[bot]

@yurkinh there has been a misunderstanding I'm not a reviewer, I think someone else should review this. Although everything seems good to me :-)

salarcode avatar Aug 11 '22 10:08 salarcode