maui [Windows] Set `CanDrag` and `AllowDrop` only if needed

[Windows] Set `CanDrag` and `AllowDrop` only if needed

Open MartyIX opened this issue 1 year ago • 3 comments

Description of Change

This PR makes it so that _container.CanDrag and _container.AllowDrop are not set unnecessarily. The PR assumes that most of UI elements are not draggable and droppable by default.

Speedscope

main: Maui.Controls.Sample.Sandbox.exe_20240524_132632.speedscope.MAIN1.json
PR: Maui.Controls.Sample.Sandbox.exe_20240524_130213.speedscope.PR1.json

-> ~9% improvement

Issues Fixed

Contributes to #21787

May 24 '24 11:05 MartyIX

/azp run

May 24 '24 11:05 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

May 24 '24 11:05 azure-pipelines[bot]

@jsuarezruiz Are the test failures real or not?

May 27 '24 08:05 MartyIX

@Foda Could you take a look please?

May 31 '24 06:05 MartyIX

@PureWeen is this good to merge?

Jun 01 '24 18:06 MartyIX

maui maui copied to clipboard

[Windows] Set `CanDrag` and `AllowDrop` only if needed

Description of Change

Speedscope

Issues Fixed

maui
maui copied to clipboard