maui
maui copied to clipboard
dotnet
Stop Android from pinning native references to system services
Android system services can have their pointers disposed of causing pinned MAUI references to error.
Description of Change
Remove all private references in Android Essentials. Resolve the service from Application.Context.GetSystemService each time
Issues Fixed
https://github.com/dotnet/maui/issues/22204
Fixes # 22204
Hey there @aritchie! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
![dotnet-policy-service[bot] avatar](https://avatars.githubusercontent.com/in/285228?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mattleibow do you recall why we ended up pinning these?
It looks like the change to do so happened in https://github.com/dotnet/maui/pull/5407 but I'm not seeing any explanation of the choice of approach.
I don't think there will be much of a perf hit here. It isn't called enough to really matter, however, I can also keep the private reference and watch the Handle == IntPtr.Zero to resolve the service again
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think this was done to try make everything faster, but we were never able to measure before net7.
Since none of these are coming up in the recent perf logs, we can just get the new service each time. If we suddenly see spikes in the perf dashboards then we can revisit.
@Redth mentioned to me offline that maybe we have the field to prevent the GC from collecting it. But, I am not sure if that was more just for iOS.
@PureWeen There was some debate around performance. I can check the Handle to keep a reference pinned, but I don't think it was necessary. Other than that, I haven't been able to get the sensor testing to work.
@aritchie what do you mean by this:
I haven't been able to get the sensor testing to work.
Does the essentials sample app not run or something?
@mattleibow Ya I've been having issues with it. I've basically written a side chunk of code to test with for now. I just haven't had the time to go back to sensors.
maybe we broke everything. We basically did 2 major changes to the build system these last few days so all is bad. Hopefully we can fix things soon and all the samples start running again :)