maui icon indicating copy to clipboard operation
maui copied to clipboard

[iOS] Readonly Editor - Scrolling fix

Open kubaflo opened this issue 1 year ago • 6 comments

Description of Change

Setting UserinteractionEnabled to false prevents the editor from scrolling, so I replaced it with changing the value of Editable based on the IsReadOnly property

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/19500

kubaflo avatar Feb 11 '24 14:02 kubaflo

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Feb 11 '24 14:02 ghost

@jsuarezruiz I added a new commit

kubaflo avatar Feb 22 '24 00:02 kubaflo

/azp run MAUI-UITests-public

jsuarezruiz avatar Mar 20 '24 16:03 jsuarezruiz

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 20 '24 16:03 azure-pipelines[bot]

/azp run MAUI-UITests-public

jsuarezruiz avatar Apr 16 '24 11:04 jsuarezruiz

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 16 '24 11:04 azure-pipelines[bot]

/azp run

jsuarezruiz avatar May 10 '24 09:05 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 10 '24 09:05 azure-pipelines[bot]

/azp run

jsuarezruiz avatar May 13 '24 10:05 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 13 '24 10:05 azure-pipelines[bot]

The test EditorIsReadOnlyPreventModify is now failing because the zone marked in red, is appearing now. EditorIsReadOnlyPreventModify-diff Is the Done Button: EditorIsReadOnlyPreventModify (1)

I think this is related with https://github.com/dotnet/maui/issues/22286

jsuarezruiz avatar May 13 '24 13:05 jsuarezruiz

The test EditorIsReadOnlyPreventModify is now failing because the zone marked in red, is appearing now. EditorIsReadOnlyPreventModify-diff Is the Done Button: EditorIsReadOnlyPreventModify (1)

I think this is related with #22286

Yea, I agree. So should we wait till this PR: https://github.com/dotnet/maui/pull/22394 gets merged?

kubaflo avatar Jun 11 '24 18:06 kubaflo

/azp run

jsuarezruiz avatar Jun 13 '24 07:06 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 13 '24 07:06 azure-pipelines[bot]

/azp run

mattleibow avatar Aug 21 '24 20:08 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 21 '24 20:08 azure-pipelines[bot]

/azp run

mattleibow avatar Aug 22 '24 16:08 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 22 '24 16:08 azure-pipelines[bot]

/azp run

mattleibow avatar Aug 23 '24 12:08 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 23 '24 12:08 azure-pipelines[bot]

/azp run

mattleibow avatar Aug 23 '24 12:08 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 23 '24 12:08 azure-pipelines[bot]