maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Fixed line break mode for buttons

Open kubaflo opened this issue 1 year ago • 1 comments

Description of Change

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/19806

Before:

https://github.com/dotnet/maui/assets/42434498/03b22b36-772b-4c6d-a2ce-7ec91f8cfb63

After:

https://github.com/dotnet/maui/assets/42434498/457f97ee-848a-40d0-a2a7-725bf7fb2223

kubaflo avatar Jan 24 '24 14:01 kubaflo

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 24 '24 14:01 ghost

MAUI/Microsoft me, this gentleman and other developers are spending a lot of time for free trying to help you improve the platform and fix bugs.

This PR seems ready to be merged or at least reviewed since three weeks ago. I have another PR waiting since October, and many other developers are on the same situation.

If MAUI team needs more devs, please tell Microsoft to hire new developers.

Now, besides the complains, can we move on with this PR? Thanks.

albyrock87 avatar Feb 22 '24 10:02 albyrock87

/azp run

jsuarezruiz avatar Feb 22 '24 13:02 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Feb 22 '24 13:02 azure-pipelines[bot]

@rmarinho I've fixed the tests Screenshot 2024-02-22 at 17 40 43

kubaflo avatar Feb 22 '24 16:02 kubaflo

@rmarinho / @albyrock87 / @StephaneDelcroix could you please have a new look at @kubaflo's code? He updated it based on your feedback, and it would really be helpful to have this issue fixed.

hansmbakker avatar Mar 04 '24 16:03 hansmbakker

Please reabse as well. The tests are very red and we think we fixed some more tests recently. Hopefully. CI is a bit dodgy.

mattleibow avatar Mar 18 '24 16:03 mattleibow

/rebase

PureWeen avatar Apr 15 '24 07:04 PureWeen

/azp run

PureWeen avatar Apr 15 '24 07:04 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Apr 15 '24 07:04 azure-pipelines[bot]

/azp run

jsuarezruiz avatar May 10 '24 11:05 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 10 '24 11:05 azure-pipelines[bot]

/azp run

jsuarezruiz avatar May 13 '24 11:05 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 13 '24 11:05 azure-pipelines[bot]

/azp run

mattleibow avatar May 28 '24 14:05 mattleibow

Hopefully I rebased correctly

mattleibow avatar May 28 '24 14:05 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 28 '24 14:05 azure-pipelines[bot]

@mattleibow Thanks!

kubaflo avatar May 29 '24 11:05 kubaflo

/azp run

mattleibow avatar May 30 '24 16:05 mattleibow

I had a bad merge there... Hopefully this fixes it.

mattleibow avatar May 30 '24 16:05 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 30 '24 16:05 azure-pipelines[bot]

@kubaflo not sure if you say https://github.com/dotnet/maui/pull/20133#discussion_r1618796655

mattleibow avatar May 30 '24 16:05 mattleibow

/azp run

jsuarezruiz avatar Jun 10 '24 13:06 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 10 '24 13:06 azure-pipelines[bot]

@kubaflo not sure if you say #20133 (comment)

I think a separate PR would be better for it

kubaflo avatar Jun 11 '24 18:06 kubaflo

/azp run

jsuarezruiz avatar Jun 13 '24 09:06 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 13 '24 09:06 azure-pipelines[bot]