maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Fixed entry text color [iOS]

Open kubaflo opened this issue 1 year ago • 7 comments

Description of Change

Added MapFormatting() for MapText in Entry.iOS like it is done in EntryHandler.iOS

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/19509 Fixes https://github.com/dotnet/maui/issues/19470 Fixes https://github.com/dotnet/maui/issues/19424

https://github.com/dotnet/maui/assets/42434498/1f951f30-62d5-4b94-b40f-844ab20b2c2a

kubaflo avatar Jan 23 '24 10:01 kubaflo

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 23 '24 10:01 ghost

You're on fire @kubaflo thank you!

jfversluis avatar Jan 23 '24 12:01 jfversluis

/azp run

jfversluis avatar Jan 23 '24 12:01 jfversluis

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 23 '24 12:01 azure-pipelines[bot]

Thanks for the contribution. I can help adding UI tests here.

jsuarezruiz avatar Jan 23 '24 12:01 jsuarezruiz

You're on fire @kubaflo thank you!

I'm still learning the MAUI codebase, but I try to be helpful! 😅

kubaflo avatar Jan 23 '24 13:01 kubaflo

Added UITest.

jsuarezruiz avatar Jan 23 '24 15:01 jsuarezruiz

/azp run

jsuarezruiz avatar Feb 02 '24 13:02 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Feb 02 '24 13:02 azure-pipelines[bot]

@jsuarezruiz @jfversluis Any update on this ?

dartasen avatar Mar 21 '24 11:03 dartasen

/azp run MAUI-UITests-public

jfversluis avatar Mar 21 '24 12:03 jfversluis

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 22 '24 12:03 azure-pipelines[bot]

@PureWeen or @jsuarezruiz any plan to move this one forward soon?

shawncothran avatar Mar 25 '24 19:03 shawncothran

Any update on when this will be merged?

Zack-G-I-T avatar Mar 26 '24 16:03 Zack-G-I-T

Also see a very lengthy discussion about this on the live stream here: https://www.youtube.com/watch?v=ERh9Ixz8f_Y

😄

@jfversluis Oh no I missed that stream :/ I rewatched it though, and must admit it was a really good one that hurts me even more that I wasn't there live haha

kubaflo avatar Apr 04 '24 23:04 kubaflo

/azp run

PureWeen avatar Apr 06 '24 15:04 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Apr 06 '24 15:04 azure-pipelines[bot]

Can u add the screen shots for all four platforms?

PureWeen avatar Apr 07 '24 04:04 PureWeen

/azp run

PureWeen avatar Apr 07 '24 17:04 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Apr 07 '24 17:04 azure-pipelines[bot]

/azp run

PureWeen avatar Apr 08 '24 13:04 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Apr 08 '24 13:04 azure-pipelines[bot]

Any updates on when this will be implemented?

ISSPRO-Eng avatar Apr 08 '24 16:04 ISSPRO-Eng

How do we utilize this fix using the Nuget Package? Or will there be a release soon

ISSPRO-Eng avatar Apr 09 '24 20:04 ISSPRO-Eng

You can try https://github.com/dotnet/maui/wiki/Nightly-Builds. I check when a nightly build was done and compare it to the moment when a PR was merged.

There was some issue when not every night, there was actually a new build but it should be fixed now. Probably still worth checking the date to be on the safe side.

MartyIX avatar Apr 09 '24 21:04 MartyIX