maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

[Housekeeping] Complete pending TODOs in Core

Open jsuarezruiz opened this issue 3 years ago • 2 comments

Description of Change

Complete pending TODOs in Core.

jsuarezruiz avatar Sep 09 '22 11:09 jsuarezruiz

Build is failing

D:\a\_work\1\s\src\Core\src\Platform\iOS\TimePickerExtensions.cs(80,44): error CS1061: 'ITimePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ITimePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\iOS\DatePickerExtensions.cs(137,44): error CS1061: 'IDatePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IDatePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\iOS\TimePickerExtensions.cs(80,44): error CS1061: 'ITimePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ITimePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\iOS\DatePickerExtensions.cs(137,44): error CS1061: 'IDatePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IDatePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBlockExtensions.cs(91,39): error CS1061: 'ILabel' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ILabel' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBoxExtensions.cs(191,39): error CS1061: 'IView' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IView' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(807,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\..\tools\net5.0\..\net472\XamlCompiler.exe" "obj\Release\net6.0-windows10.0.20348\\input.json" "obj\Release\net6.0-windows10.0.20348\\output.json"" exited with code 1. [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBoxExtensions.cs(191,39): error CS1061: 'IView' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IView' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBlockExtensions.cs(91,39): error CS1061: 'ILabel' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ILabel' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(807,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\..\tools\net5.0\..\net472\XamlCompiler.exe" "obj\Release\net6.0-windows10.0.19041\\input.json" "obj\Release\net6.0-windows10.0.19041\\output.json"" exited with code 1. [D:\a\_work\1\s\src\Core\src\Core.csproj]
    10 Warning(s)

It seems that we have removed the GetEffectiveFlowDirection extension method, any specific reason?

jsuarezruiz avatar Sep 27 '22 11:09 jsuarezruiz

Build is failing

D:\a\_work\1\s\src\Core\src\Platform\iOS\TimePickerExtensions.cs(80,44): error CS1061: 'ITimePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ITimePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\iOS\DatePickerExtensions.cs(137,44): error CS1061: 'IDatePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IDatePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\iOS\TimePickerExtensions.cs(80,44): error CS1061: 'ITimePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ITimePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\iOS\DatePickerExtensions.cs(137,44): error CS1061: 'IDatePicker' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IDatePicker' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBlockExtensions.cs(91,39): error CS1061: 'ILabel' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ILabel' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBoxExtensions.cs(191,39): error CS1061: 'IView' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IView' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(807,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\..\tools\net5.0\..\net472\XamlCompiler.exe" "obj\Release\net6.0-windows10.0.20348\\input.json" "obj\Release\net6.0-windows10.0.20348\\output.json"" exited with code 1. [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBoxExtensions.cs(191,39): error CS1061: 'IView' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'IView' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBlockExtensions.cs(91,39): error CS1061: 'ILabel' does not contain a definition for 'GetEffectiveFlowDirection' and no accessible extension method 'GetEffectiveFlowDirection' accepting a first argument of type 'ILabel' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Core\src\Core.csproj]
C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\Microsoft.UI.Xaml.Markup.Compiler.interop.targets(807,9): error MSB3073: The command ""C:\Users\cloudtest\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\..\tools\net5.0\..\net472\XamlCompiler.exe" "obj\Release\net6.0-windows10.0.19041\\input.json" "obj\Release\net6.0-windows10.0.19041\\output.json"" exited with code 1. [D:\a\_work\1\s\src\Core\src\Core.csproj]
    10 Warning(s)

It seems that we have removed the GetEffectiveFlowDirection extension method, any specific reason?

Could I recover the extension method?

jsuarezruiz avatar Oct 13 '22 11:10 jsuarezruiz

To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR is not included in the next release so I close it for now. I will reopen it and adapt to changes later.

jsuarezruiz avatar Nov 03 '22 08:11 jsuarezruiz