LLVMSharp icon indicating copy to clipboard operation
LLVMSharp copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Was there any discussion around the removal of LLVMSharp.API?

Open ericsink opened this issue 5 years ago • 5 comments

All the LLVMSharp.API stuff was removed in commit

bc6c79b4e418a82514a99d6885ad43e21bbd55cc

back in June.

I've been looking around trying to find discussion around this change, but I'm not seeing it. Does anyone have any further context?

I assume that OO-style API (1) was removed intentionally, and (2) didn't move somewhere else, and (3) is not planned to come back. Is all that correct?

Before I migrate my code to the lower-level API, I just wanted to make sure I'm not missing something.

Thanks!

ericsink avatar Mar 16 '20 17:03 ericsink

There was some discussion on the actual PR: https://github.com/microsoft/LLVMSharp/pull/105

The low level bindings made generating and picking up updates much easier (and ensured the lowest level API was correct). However, it also meant that the entire LLVMSharp.API needs to be rewritten. An equivalent of LLVMSharp.API can and likely should be implemented, but it isn't something that is being actively worked on right now.

tannergooding avatar Mar 16 '20 18:03 tannergooding

Ah, that's very helpful. Thanks.

ericsink avatar Mar 16 '20 18:03 ericsink

@ericsink If you need something like LLVMSharp.API perhaps I could discuss it with @tannergooding and see what we can generate from what we have now. So far I just had assumed there was no interest in that namespace.

TChatzigiannakis avatar Mar 17 '20 08:03 TChatzigiannakis

Nah, I'm fine. I'm making good progress switching things over.

ericsink avatar Mar 17 '20 15:03 ericsink

I've started the work on a replacement for LLVMSharp.API here: https://github.com/microsoft/LLVMSharp/pull/137

tannergooding avatar Apr 18 '20 21:04 tannergooding