Don McCurdy
Don McCurdy
Alright, this PR is just the docs portion now. It links to the unpkg CDN when the user clicks "Download", so for the moment there's no dependency on the unmodularize...
Checking in on this PR again, given #18749 — if we want this import section in the docs, should the section just describe ES module import? Or should it also...
Related: https://github.com/mrdoob/three.js/pull/19622
I've reverted this to a draft for now — let me update the PR to match up with https://github.com/mrdoob/three.js/pull/19622 better.
Updated to include only 'npm' and 'cdn' options, both using ES modules. If this is something we want to merge, I can add the changes to the other pages.
Will reopen if there's interest in adding examples of how to import on these docs pages.
based on [careful user observation](https://youtu.be/Hx5-XwYvgn8?t=2966), I would like to suggest again that we consider import docs on examples. 😅
Ok! Is https://raw.githack.com/donmccurdy/three.js/feat-unmodularize/docs/index.html#examples/en/loaders/GLTFLoader still what we want this to look like on all (?) `examples/jsm` docs pages? (ignore that the branch name is "-unmodularize", this is just adding content to...
Similar to the conversation in https://github.com/mrdoob/three.js/pull/8953 about SkinnedMesh, I've been getting multiple issues reported on my viewer (https://github.com/donmccurdy/three-gltf-viewer/issues/147) because the viewport (determined with `Box3().setFromObject(...)`) does not factor in skinning deformations....
Could you share a model so that we can reproduce this? You can drag .ZIP files into GitHub comments.