migrations icon indicating copy to clipboard operation
migrations copied to clipboard

Store version description into migrations table

Open alOneh opened this issue 6 years ago • 3 comments

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

It could be a nice feature to have the description we provide in the Migration class generated filled also in the migration_versions table.

The idea is to have a new column description in the migration_versions table to see what happens without going to the source code. Could be interesting for dba or release manager.

alOneh avatar Sep 06 '19 07:09 alOneh

What's the motivation for keeping that? Note that I'm not saying we shouldn't do it, I'm just trying to understand the use-case.

alcaeus avatar Sep 06 '19 10:09 alcaeus

To be honest, at the first time I discuss about that with a colleague who wants to separate logically the migration classes by the sprint number (agile mode) to know what db changes we made during the given sprint number. But for me it was really weird, so I dig into the code and see that we can use the description for that but the inconvenient is that it is not persisted in the db.

So the motivation for keeping that is only to keep track of that information, this description is only use when you run the migrate command but if you want to know what a version does without having access to the source code the migration_versions table does not tell you that and you only have the reference to the version number.

Hope it helps.

alOneh avatar Oct 10 '19 21:10 alOneh

My initial reaction is I don't feel this should be a part of the migrations tool. I think it should probably be accomplished outside of the production database and the database migrations tool. Most likely somewhere in the project management tooling.

jwage avatar Oct 10 '19 21:10 jwage