docsify icon indicating copy to clipboard operation
docsify copied to clipboard

[fix #1467] Make sure target attribute is kept after DOMPurify sanitization

Open Fab1en opened this issue 4 years ago • 3 comments

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Repo settings
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [x] Firefox 84
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Fab1en avatar Jan 02 '21 03:01 Fab1en

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/BkCKuc1cvzzh5yoySjR62UL9jzFK
✅ Preview: https://docsify-preview-git-fork-fab1en-develop-docsify-core.vercel.app

vercel[bot] avatar Jan 02 '21 03:01 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70c84aafcb3eaa11a87ed46bcd3ca0730917598c:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Jan 02 '21 03:01 codesandbox-ci[bot]

DOMPurify will likely be removed shortly. See #1490.

jhildenbiddle avatar Feb 05 '21 04:02 jhildenbiddle