php icon indicating copy to clipboard operation
php copied to clipboard

Published 20 hours ago • verified publisher icon docker-library

Fix conditional "strip" based on "ZEND_DEBUG_BUILD"

Open mvorisek opened this issue 3 years ago • 4 comments

strip --strip-all is present on two places, in https://github.com/docker-library/php/pull/1278, it was made conditional for modules, this PR makes it conditional also for the main binaries

mvorisek avatar Mar 26 '22 15:03 mvorisek

I'm a bit less convinced on this one -- for this new if to ever not execute, you've already got to be editing the Dockerfile, right?

tianon avatar Mar 28 '22 23:03 tianon

Yes, you are correct, I am updating the Dockerfile with sed to add --enable-debug. However, I think this condition is non-intrusive and 1:1 used in https://github.com/docker-library/php/pull/1278.

mvorisek avatar Mar 29 '22 06:03 mvorisek

How about using this together with my idea? https://github.com/docker-library/php/pull/1287

enumag avatar Apr 04 '22 16:04 enumag

Can this PR be merged? If the template is modified or the DockerFile directly, with this PR, the debug build is detected correctly, and as this align the condition introduced in #1278, I belive such unified check is better than any other condition.

mvorisek avatar Apr 15 '22 18:04 mvorisek