nova-medialibrary-field icon indicating copy to clipboard operation
nova-medialibrary-field copied to clipboard

Nova 4 support

Open illambo opened this issue 3 years ago • 9 comments

Any plan about support for laravel nova 4? Thanks

illambo avatar Apr 07 '22 08:04 illambo

@illambo Hi, don't really have time to support this package

dmitrybubyakin avatar Apr 07 '22 10:04 dmitrybubyakin

Ok thanks

illambo avatar Apr 07 '22 11:04 illambo

I see this fork with a few commits for Nova 4. You may want to try that out.

ChristianPavilonis avatar Apr 22 '22 21:04 ChristianPavilonis

Hello, I will open a PR in the following days. I am getting quite close here. Apart from other stuff I still have to make generated conversions work, fix tests and so on. But if someone wants to try it with Nova 4 installation, the crucial parts are working ok now.

repl6669 avatar Apr 25 '22 03:04 repl6669

hi @theimerj Thank you for the efforts to make this compatible with Nova 4!

I couldn't find where to open an issue in your fork. so i'll add it here.

the id of the field is not generated correctly, it's id="inputundefined" and when having multiple fields in the same resource only the first one works. Screen Shot 2022-05-01 at 12 54 48

sp4r74cus avatar May 01 '22 10:05 sp4r74cus

Hello @sp4r74cus, I opened the issue tab in the fork, so we can move the conversation there.

repl6669 avatar May 01 '22 11:05 repl6669

Hello everyone, the PR #160 just landed. Please help out with testing and adjustments, if you can. It is not 100% done, it still needs quite some polishing.

@dmitrybubyakin could you please remove the #159 i accidentally created from wrong branch? Thank you.

repl6669 avatar May 03 '22 15:05 repl6669

any news on this?

tmartty avatar Aug 01 '22 10:08 tmartty

any news on this?

Actually yes, @kreejzak is looking into it and we will merge soon.

repl6669 avatar Aug 01 '22 10:08 repl6669