druntime

druntime copied to clipboard

It's valid C11: https://en.cppreference.com/w/c/language/_Alignof

Thanks for your pull request and interest in making D better, @ryuukk! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3840"

Done, i also added __alignof, i got that one when using the clang preprocessor on windows

it seems dmd already handles this https://github.com/dlang/dmd/blob/master/src/dmd/cparse.d#L900 please determine if this is still needed (e.g. for __alignof)

it seems dmd already handles this https://github.com/dlang/dmd/blob/master/src/dmd/cparse.d#L900 please determine if this is still needed (e.g. for __alignof)

I might have an outdated version of dmd, i'll try with latest master changes

@ryuukk any progress?

Adding the 72h no response -> close label.