django-plans icon indicating copy to clipboard operation
django-plans copied to clipboard

Automatic publish to PyPI

Open Alir3z4 opened this issue 4 years ago • 18 comments

For each release, the package should be automatically published to PyPI. Github actions can be triggered by each tag, once a tag is created on the repository, an action can get executed and publish to PyPI.

Blocked by: https://github.com/django-getpaid/django-plans/issues/133

Alir3z4 avatar Oct 09 '21 11:10 Alir3z4

@Alir3z4 Should I somehow help with this?

I think we should make a PyPI release as soon as possible (automatic or not), because there are many fixes, especially of compatibility with newer Django versions. The new release should include MRs #155, #154, #152, #151, #149 (all are mostly bugfixes).

PetrDlouhy avatar Jan 19 '22 08:01 PetrDlouhy

@Alir3z4 Could you please merge the #158 and #152 MRs?

What about the PyPI release? Can I help it somehow?

PetrDlouhy avatar Feb 08 '22 12:02 PetrDlouhy

@Alir3z4 I think we should release new PyPI version now, the current doesn't work in with newer Django/Python versions. None of the remaining MRs are mandatory for the new release (although #159 may be nice).

PetrDlouhy avatar Feb 24 '22 08:02 PetrDlouhy

I cannot setup automatic publishing to PyPI unless my privileges gets escalated so I can add environment variables for Twine.

Probably @cypreess can help with that or he can add his own credentials to the GitHub Actions environment variables. I've already done something like this in another project of mine at https://github.com/Alir3z4/python-currencies/blob/master/.github/workflows/python-publish.yml

Alir3z4 avatar Feb 26 '22 15:02 Alir3z4

Any updates?

alamothe avatar Jul 04 '22 23:07 alamothe

@PetrDlouhy @Alir3z4 @cypreess Hi there, sorry to bother you, but a new version of this package hasn't been released for over 4 years now, even though there has been active development recently.

Can anyone suggest a way to overcome this impasse? I am ready to do my part, which is to help with the bare minimum maintenance tasks (updating support for newer django versions and fixing critical bugs).

nemesifier avatar Sep 01 '22 14:09 nemesifier

@nemesisdesign I have no rights to this repo nor PyPI package, so its on @Alir3z4.

I did most of the maintanence work as well as some development. I think the project is mostly ready for new release.

There are PRs I have made that might be good to pull before release (but it is not needed):

  • #173 But it fixes only the demo app, so no change for production usage.
  • #172 Fix for tests, no change in production usage.
  • #162 Change in Billing info. Not needed for release.

PetrDlouhy avatar Sep 01 '22 19:09 PetrDlouhy

@PetrDlouhy @nemesisdesign I invited both of you with Writers privileges into this project, so please continue to maintain this repository and merge all PRs that you feel are appropriate.

I am sadly not able to maintain this project anymore.

cypreess avatar Sep 06 '22 09:09 cypreess

I also do not have for some unknown reasons privileged to PyPi project, @Alir3z4 can you maybe check this out as you have access and make all of us here maintainers on PyPI as well.

cypreess avatar Sep 06 '22 09:09 cypreess

Thanks @cypreess for granting access.

I already merged https://github.com/django-getpaid/django-plans/pull/173 since it's a safe and small change, then reviewed https://github.com/django-getpaid/django-plans/pull/172.

nemesifier avatar Sep 07 '22 07:09 nemesifier

@cypreess the only person alongside me that has access on PyPI is https://pypi.org/user/swapps/

Can you all give me your PyPI usernames to give everyone access?

Alir3z4 avatar Sep 11 '22 18:09 Alir3z4

My PyPI username is petr.dlouhy

PetrDlouhy avatar Sep 11 '22 20:09 PetrDlouhy

My PyPI username is petr.dlouhy

Invited.

Alir3z4 avatar Sep 11 '22 22:09 Alir3z4

@Alir3z4 I am nemesisdesign: https://pypi.org/user/nemesisdesign/

nemesifier avatar Oct 04 '22 10:10 nemesifier

OK, I resubmitted #172 in #174 to use mocking everywhere. The new version is still not released. Are we waiting for something, or should I just release it?

PetrDlouhy avatar Oct 04 '22 16:10 PetrDlouhy

@PetrDlouhy have you got access to pypi to issue new releases?

nemesifier avatar Oct 25 '22 12:10 nemesifier

Yeah, now I have the rights. I will make the release.

PetrDlouhy avatar Oct 25 '22 15:10 PetrDlouhy

New version is now released. Please write if there are any problems with it.

PetrDlouhy avatar Oct 25 '22 15:10 PetrDlouhy