wp-discourse icon indicating copy to clipboard operation
wp-discourse copied to clipboard

Login path issue with WordPress cookies.

Open saas786 opened this issue 3 years ago • 0 comments

Why its necessary to set relative path like /login?

Ref: /wp-admin/admin.php?page=wp_discourse_options&tab=sso_provider&parent_tab=sso_options

Loom_lWQkANo9kq


As it causes issue on WordPress $secure cookie, because of PHP_URL_SCHEME, it doesn't return https, because its not available when /login is set, hence $secure is set to false, hence causing issues for users.

Ref: https://github.com/WordPress/WordPress/blob/6.0.1/wp-login.php#L477


As plugin has validate_login_path() set, which doesn't allow for https://website.com/login

ref: https://github.com/discourse/wp-discourse/blob/2.4.5/admin/settings-validator.php#L678

saas786 avatar Aug 24 '22 07:08 saas786