discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

Update nodejs engine to 18

Open JMTK opened this issue 2 years ago • 3 comments

Which application or package is this feature request for?

discord.js

Feature

Nodejs 16 is now EOL as of September 11 2023 and 18 is now LTS https://nodejs.dev/en/about/releases/

Ideal solution or implementation

Update all package engines to be 18+.

Experimental fetch is now enabled by default and can probably replace any undici references.

Alternative solutions or implementations

No response

Other context

No response

JMTK avatar Oct 10 '23 03:10 JMTK

This will occur no earlier than the next major version (has already been done in many other packages).

Also of note, undici references will not be removed in discord.js. The main library is not intended to be used in browser environments, and undici request is more stable than fetch. Anything that can be used in browser / edge environments has already been updated to use global fetch when not in node (this includes in deno / bun).

ckohen avatar Oct 10 '23 03:10 ckohen

Seems like this issue can be closed: https://github.com/discordjs/discord.js/commit/ee2afb0aaed17648c46916220404d1fba1bd0147

JMTK avatar Nov 08 '23 11:11 JMTK

discord.js is still on v16. As @ckohen said

This will occur no earlier than the next major version

Syjalo avatar Nov 08 '23 14:11 Syjalo