David Heinemeier Hansson
David Heinemeier Hansson
Sounds good to me 👍
Happy to see this. We already have a specialized version of this for Traefik. So you can follow that pattern 👍
Sorted via https://github.com/mrsked/mrsk/pull/95
You sure you checked in those files into git? Almost looks like vendor/javascript might not be under version control, so the files only exist locally?
Let's just test against Rails 7+.
Would be nice to switch this to kwargs. Do investigate a PR.
This looks correct to me at a glance. `data-remote` is dead, since Turbo automatically processes all forms. But I'm a bit concerned that this is too aggressive of a depreciation...
On second thought, I think this is fine. Changing remote: true to "data-remote": true in order to deal with the deprecation warning is not a huge imposition. And if not...
Thanks for reviving this. But I was thinking that maybe we should just bring out the big knife, totally cut this out, and then present a gem to bring it...
Please do fill in all the missing tests 🙏