gix-components icon indicating copy to clipboard operation
gix-components copied to clipboard

Radio toggle component

Open mstrasinskis opened this issue 1 year ago • 3 comments

Motivation

A radio group component to be used first on the proposals page.

Changes

  • RadioToggle compoent

Test

  • RadioToggle

Screenshots

image image

mstrasinskis avatar Feb 26 '24 17:02 mstrasinskis

Can we perhaps use Segment and SegmentButton, like we use here to switch between ckBTC and Bitcoin on the receive modal?

image

dskloetd avatar Feb 27 '24 13:02 dskloetd

Can we perhaps use Segment and SegmentButton, like we use here to switch between ckBTC and Bitcoin on the receive modal?

Perhaps we could, but this means to support 2 different themes for the component with different styles / widths.

image image

Let me evaluate it.

mstrasinskis avatar Feb 27 '24 15:02 mstrasinskis

I think we should be careful about adding new design elements every time we add a new feature and try to reuse components as much as possible. Would be could if you could check with PM/UX if this can be reused. Maybe by adjusting either the existing component or the new feature. Thanks!

dskloetd avatar Feb 27 '24 16:02 dskloetd

Closing this PR as it’s no longer relevant.

mstrasinskis avatar Dec 23 '24 17:12 mstrasinskis