Kakapo icon indicating copy to clipboard operation
Kakapo copied to clipboard

Refactor Kakapo to not be json centric WIP

Open MP0w opened this issue 9 years ago • 5 comments

This is a draft PR to address #153, I want some feedback before proceeding with updating the documentation, README, tests The idea is that Router now doesn’t work anymore w/ Serializable objects and ResponseFieldsProvider is not anymore a special Serializable. Router now only accept ResponseFieldsProviders an object that provides: statusCode (Int) headerfields (dict) body (data)

Serializable became a ResponseFieldsProvider that by default has a status code == 200 and “Content-Type” == “application/json”. It should have been like that since ever, so we can use Kakapo with images, xml or whatever we want by creating new ResponseFieldsProvider

The change is a breaking change but not a big one for users of Kakapo (only objects that were confirming to ResponseFieldsProvider will be broken)

MP0w avatar Mar 19 '17 11:03 MP0w

@zzarcon might be interesting also for Kakapo.js 🤷‍♂️

MP0w avatar Mar 19 '17 11:03 MP0w

1 Error
:no_entry_sign: Any changes to library code need a summary in the Changelog.

Generated by :no_entry_sign: Danger

devluckybot avatar Mar 19 '17 11:03 devluckybot

+1 for this cos we need to use this to mock binary protobuf response. any updates?

tflhyl avatar Oct 21 '17 07:10 tflhyl

@MP0w can you give us an update on this? is the project dead? 😢

zzarcon avatar Dec 01 '17 03:12 zzarcon

hey @MP0w, same as @zzarcon, is the project dead ?

gomera avatar Mar 22 '18 14:03 gomera