Mattias Karlsson

Results 126 comments of Mattias Karlsson

Sure sounds like a good addition 1. IsPullRequest 2. Unsure, SYSTEM_PULLREQUEST_PULLREQUESTID feels more correct, but not read docs, what do they say?

Easiest initially would be to expose `RedirectedStandardOutputHandler` and `RedirectedStandardErrorHandler` on `ToolSettings`, which was just recently added to ProcessSettings in pr #2447 That would allow user to optin to do some...

Redirecting all output could have major side effects as some tool aliases use the output in various ways. But adding an `CakeToolException` that inherits from current one but adds exit...

Regardless exposing `RedirectedStandardOutputHandler` and `RedirectedStandardErrorHandler` on `ToolSettings` should be done, I'll raise a separate issue about that. Attaching ExitCode, StdErr & StdOut to "cake tool exception" would be very useful,...

`#tool` preprocessor only downloads tool, but doesn't reference assembly, so issue likely manifests itself because presence of tools lets code come further. By inspecting your log it doesn't seem like...

It's inherited from [DotNetCoreSettings](https://github.com/cake-build/cake/blob/cb90c043d307a494d52d44a060504cc34542166a/src/Cake.Common/Tools/DotNetCore/DotNetCoreSettings.cs#L17) Common `--verbosity` was obsoleted in .NET Core 2.x, and removed in 2.1.4xx, so we should obsolete now with errror, and remove next version. Reference discussion around...

It's not been avail for 1 year, and didn't work as expected before that. So my vote is on obsolete :)

Could we obsolete in base and do a new property in DotNetCoreMSBuildSettings? Maybe a MSBuildVerbosity enum as Vebosity is Cake verbosities which doesn't totally match MSbuild but instead gets translated...

@agc93 just checking, will you be able to look at this in a near future or should we bump it to next release?