cli icon indicating copy to clipboard operation
cli copied to clipboard

devcontainer.json file's customizations of the project override feature's customizations

Open erdaltsksn opened this issue 3 years ago • 4 comments

When there are the same vscode settings in both feature's and the project's devcontainer.json file, the project's customizations override the feature's. Is it possible to merge it instead of an override?

  • devcontainer.json file at the features:
{
    "customizations": {
        "vscode": {
            "settings": {
                "files.associations": {
                    "LICENSE*": "plaintext"
                }
            }
        }
    }
}
  • devcontainer.json file at the project:
{
    "customizations": {
        "vscode": {
            "settings": {
                "files.associations": {
                    "commit-msg-template": "git-commit"
                }
            }
        }
    }
}

Expected Result:

{
    "customizations": {
        "vscode": {
            "settings": {
                "files.associations": {
                    "LICENSE*": "plaintext",
                    "commit-msg-template": "git-commit"
                }
            }
        }
    }
}

Current Result:

{
    "customizations": {
        "vscode": {
            "settings": {
                "files.associations": {
                    "commit-msg-template": "git-commit"
                }
            }
        }
    }
}

erdaltsksn avatar Nov 12 '22 21:11 erdaltsksn

Transferring to CLI repo

Chuxel avatar Nov 14 '22 17:11 Chuxel

/cc @chrmarti Is this expected? I would have expected a merge of objects by default.

Chuxel avatar Nov 14 '22 17:11 Chuxel

I have also ran into this snag, and was curious if there's any immediate plans to address it?

If not, could someone point me in the general location of where settings are handled in the code base and I could look at contributing a fix for this?

jereklas0902 avatar Aug 08 '23 20:08 jereklas0902

@chrmarti Any update about this bug?

erdaltsksn avatar Nov 09 '23 19:11 erdaltsksn