exo icon indicating copy to clipboard operation
exo copied to clipboard

[FEATURE] enhanced shell completions

Open brandonbloom opened this issue 4 years ago • 7 comments
trafficstars

As of #213, we have support for static shell completions. There are a few enhancements to make:

  1. more robust install support for linux and windows
  2. automatic installation as part of our install script
  3. dynamic completions, for example, completing component names on commands like exo start ...

This is all relatively low priority, but (3) in particular is probably a good "help wanted" feature for new commers!

brandonbloom avatar Sep 02 '21 23:09 brandonbloom

Let's say that this is blocked by #301.

brandonbloom avatar Oct 06 '21 22:10 brandonbloom

I had difficulty getting completions to generate on Fish. I have no clue why, as pkg-config --variable completionsdir fish seems to resolve the proper directory, and exo completion generate fish works fine to output a completions file (I was able to just pipe that where it belonged). I'm not sure if this should be a new issue or could be attached to this one, but I'll start here.

I wrote up my solution (to help others) here: https://stackoverflow.com/questions/70010126/generating-completions-file-for-exo-in-fish/70010127#70010127 I tried to tag it as exo but I don't have 1500 reputation so couldn't create the tag.

MaxmumP avatar Nov 17 '21 19:11 MaxmumP

cc @BenElgar who can help with installer and shells stuff

brandonbloom avatar Nov 17 '21 20:11 brandonbloom

I'm hoping #528 improves the fish use case.

BenElgar avatar Nov 18 '21 13:11 BenElgar

Thanks @BenElgar!

@MaxmumP, we'll let you know when this lands in the next release & maybe you can give it a try and let us know how it works. Thanks for the report.

brandonbloom avatar Nov 18 '21 22:11 brandonbloom

Yeah, that looks great. I had assumed you had already been using pkg-config to find the completions directory. Was impressed at how fast @BenElgar got that in! :-)

MaxmumP avatar Nov 19 '21 00:11 MaxmumP

This was prematurely closed along with the Fish fix. Automatic installation and dynamic completions are not yet implemented.

brandonbloom avatar Jan 25 '22 01:01 brandonbloom