exo icon indicating copy to clipboard operation
exo copied to clipboard

[BUG] docker compose volume & network with same name conflict on import

Open brandonbloom opened this issue 4 years ago • 5 comments

see title - it's b/c compose namespaces by type, and we namespace within a workspace

brandonbloom avatar Aug 24 '21 21:08 brandonbloom

What would we consider a good solution to this? Should we just adopt any volume that happens to have the appropriate name?

BenElgar avatar Sep 01 '21 13:09 BenElgar

This bug is unrelated to component adoption. It's more similar to having invalid characters in the name. We should detect conflicts on import and add a suffix or something to the component name (but not the container/volume/network name in docker) to disambiguate them.

brandonbloom avatar Sep 01 '21 15:09 brandonbloom

And if we do this, we should emit a warning :)

brandonbloom avatar Sep 01 '21 15:09 brandonbloom

Oh sorry, I understand. This is about volumes and networks with the same name as each other. I thought it was about conflicting with docker compose.

BenElgar avatar Sep 01 '21 15:09 BenElgar

Added "good first issue" because this should be entirely contained within compose/convert.go and similar to res.AddRenameWarning(originalName, name)

brandonbloom avatar Sep 02 '21 23:09 brandonbloom