yii2-user icon indicating copy to clipboard operation
yii2-user copied to clipboard

Published 20 hours ago • verified publisher icon dektrium

introduce allowImpersonateForRoles and denyImpersonateIntoRoles

Open thyseus opened this issue 7 years ago • 5 comments

Q A
Is bugfix? no
New feature? yes
Breaks BC? no

  • Security related improvements about impersonating

thyseus avatar Mar 01 '18 19:03 thyseus

LGTM

schmunk42 avatar Mar 02 '18 10:03 schmunk42

Cool. Did not know LGTM yet. Looks great. But it says:

ERROR: Could not detect a suitable build command for the source checkout.

thyseus avatar Mar 02 '18 10:03 thyseus

ERROR: Could not detect a suitable build command for the source checkout.

I meant "Looks good to me" :) and you?

schmunk42 avatar Mar 02 '18 10:03 schmunk42

Hahahaha i thought you mean https://lgtm.com :)

Thanks for reviewing. I already use this code in my live environments, if you have any idea or suggestion, let me know.

thyseus avatar Mar 02 '18 10:03 thyseus

I have good news. @dmeroff has risen from the darkness and said that he will return to evaluate the PRs!

Let's wait for your word.

thiagotalma avatar Mar 02 '18 19:03 thiagotalma