James Leahy

Results 22 comments of James Leahy

Localizing plurals is quite tricky as different languages have different grammatical rules. For instance: | Text | en | de | pl | | ----------- |---------------|-----------------|---------------| | 1 + second...

@expilu @ThomasEcalle @deadsoul44 Here is a potential solution using's intl package: https://github.com/smartnsoft/FlappyTranslator/pull/20

@expilu Yes I quite like intl too and believe it is a good solution for plurals and gender :)

**TL;DR** Plurals and Genders are out of scope of _flappy_translator_ and won't be worked on. The goal of _flappy_translator_ is to automatically generate `LocalizationDelegate`s using the [alternative approach](https://flutter.dev/docs/development/accessibility-and-localization/internationalization#alternative-internationalization-workflows). This workflow...

Happy to announce that [arb_generator](https://pub.dev/packages/arb_generator) is presently being worked on. The initial alpha version already supports variables, plurals, genders and select. Feel free to [star the repo](https://github.com/defuncart/arb_generator) to receive updates...

@ditman @stuartmorgan The [original PR](https://github.com/flutter/plugins/pull/6715) was opened 3 months ago, would be nice to get some feedback on the api. I think this is a feature that can benefit flutter...

@ditman @stuartmorgan Thanks for the review. As more options may come in the future (i.e. mute, autoplay), I'd split the control options out to their own model `VideoPlayerWebOptionsControls` for a...

@ditman Added `allowPictureInPicture` and `allowRemotePlayback` options. As picture-in-picture is displayed in controls list, I've added the option to `VideoPlayerWebOptionsControls`. If you are happy with the API, then I can add...

@ditman Update function definition to be correct. Does 'override: no versioning needed' need to be added so that repo_checks can succeed?

@stuartmorgan @ditman What type of tests are expected here? How can `kIsWeb` be mocked?