Charles Truong

Results 22 comments of Charles Truong

> I observed about the same asymptotic timings using the new method (displayed as ruptures cumsum in figure) as the old method (displayed as ruptures l2). I do not know...

Many thanks. I will take a look this week.

sorry for the delay, I'm starting to go through your PR

Also can you format your code (I personnaly use flake8). Note that I do not mind long lines (for now). For now, it is not well enforced in the rest...

Can you resend me the invite link to your fork? I'd like to correct some minor things.

I have added several commits to your PR. However the documentation is not clear enough: - the equation of cost functions do not seem right, can you clarify them. -...

> Could you explain about the detail why the equation of cost functions seem not right? You are right, the equation is ok. I thought that $\bar{y}_t$ referred to the...

Hi Romain, Thanks for you message. This would indeed be a great addition to have more metrics. For the adjusted Rand Index, I do not mind to have scikit-learn as...

Hi, Thanks for the comment. Indeed, the documentation needs some improvement. I'll be sure to add your suggestion first. Certainly in Section "Gallery of examples".

Very good point. I'll the issue open to remind me to add it to the docs (shortly hopefully).