Chansung Park

Results 145 comments of Chansung Park

@gante > @deep-diver am I right in saying that the component proposed in https://github.com/tensorflow/tfx-addons/pull/174 would push the TFX model to the HF Hub, and that this component would create a...

regarding @gante's comment, I think `HFSpacePusher` works with `HFModelPusher` is the best. Even if `HFSpacePusher` might be useless without `HFModelPusher` in this case, it still makes sense in two ways:...

Fair enough! Then, let's go with `HFModelPusher` optionally enabling space app generation. If the component gets bigger and complier, we can decide to split them later. @gante how Gradio team...

@rcrowe-google thanks for jumping in! This PR is going to be closed since this feature will be included in the HFModelPusher(#174) component. It is just open for further discussions for...

Thanks for the comment @casassg :) Will check out the `CONTRIBUTING.md`, and I will request reviews by today or tomorrow

@casassg should I write unit tests? I have checked it works

@casassg some tests are added

@sayakpaul addressed your comments :) @casassg ready to have your reviews :D

addressed your comments @casassg

when I run `pip install --dry-run --ignore-installed -e ".[ci_min, firebase_publisher]"`, I get the following error: `ERROR: No matching distribution found for tfx=1.4.0; extra == "firebase_publisher"`