sidetree icon indicating copy to clipboard operation
sidetree copied to clipboard

Published 20 hours ago • verified publisher icon decentralized-identity

controller string should be populated to be more consistent with other DID implementations

Open troyronda opened this issue 4 years ago • 3 comments

Re: https://github.com/decentralized-identity/sidetree/pull/1009#discussion_r561435869

https://github.com/decentralized-identity/sidetree/pull/1006#discussion_r561056101 @OR13 wrote:

I strongly recommend against returning the empty string for the controller property.... if makes sidetree look different than every other did method, and its not guaranteed to work accross JSON-LD implementations... the controller property should match the didDocument.id.

I agree - it is better to populate the controller property rather than leave it empty.

@thehenrytsai @OR13 @csuwildcat @sandrask @isaacJChen

troyronda avatar Jan 21 '21 13:01 troyronda

Is this a v1 issue?

OR13 avatar Feb 02 '21 21:02 OR13

For example: https://github.com/transmute-industries/sidetree.js/blob/main/packages/test-vectors/src/sidetree-universal-wallet/wallet-operation.json#L37

^ we support controller like this.

OR13 avatar Feb 02 '21 21:02 OR13

This isn't a consistency issue... this is a compliance issue.

From did-core:

controller The value of the controller property MUST be a string that conforms to the rules in § 3.1 DID Syntax.

llorllale avatar Mar 02 '21 23:03 llorllale