did-key.rs

did-key.rs copied to clipboard

Example program doesn't compile; complains about `alloc` needing to be enabled

2

This trivial program doesn't compile: ```rust use did_key::Fingerprint; fn main() { match did_key::resolve("did:key:z9Bg7Lbpq3RzgN8RkgEuZqLDF4nT1ZzobJe9ZPbS6HJpQ") { Ok(k) => println!("{:?}", k.fingerprint()), Err(e) => println!("{:?}", e), } } ``` The output is: ``` ❯...

haarts

ed25519-dalek has new `SigningKey` and `VerifyingKey` types to make it more mis-use resistant see: https://github.com/MystenLabs/ed25519-unsafe-libs | https://rustsec.org/advisories/RUSTSEC-2022-0093.html

pinkforest

The README says: > This crate is intended to provide basic support for did:key methods. It has no external dependencies and can be compiled for any target. But there clearly...

TheButlah

I have been reading the code and saw this: https://docs.rs/did-key/latest/src/did_key/ed25519.rs.html#40 The bitwise operations appear to be from [here](https://www.rfc-editor.org/rfc/rfc7748#section-5): Is there a function perhaps in `curve25519-dalek` that performs this same stuff?...

TheButlah

It should be possible to zeroize memory, especially for the private key parts. If this sounds like a welcome feature, happy to work on a PR at some point!

blaine

Hello, we would like to point out a potential issue that you might want to prevent. The `did-key` crate depends on `did_url` which in turn depends on `form_urlencoded`. The latter...

PhilippGackstatter

v0.0 branch?

7

Due to the breaking change mess with funty (see https://github.com/myrrlyn/funty/issues/3), I'm finding it a bit intractable to upgrade my dependency on did-key.rs to 0.1. Would you be open to having...

vdods

BLS test vectors don't resolve correctly

3

More test cases here: https://github.com/LedgerDomain/did-key.rs/blob/main/src/lib.rs In particular, the BLS key type test vectors don't resolve correctly. There's a difference between the did-key crate generated BLS keys, which start with `did:key:z5T`...

vdods