DIDComm-js icon indicating copy to clipboard operation
DIDComm-js copied to clipboard

Published 20 hours ago • verified publisher icon decentralized-identity

fix: Incorrect Base64URL encoding used

Open kg0r0 opened this issue 5 years ago • 4 comments

Fixed https://github.com/decentralized-identity/DIDComm-js/issues/21

kg0r0 avatar Apr 10 '20 13:04 kg0r0

just noting, I'll bring this up on the next DID-Auth call, so we can get this through ASAP without breaking anyone. When this was discussed in the Aries WG, we recognized it was a breaking change but accepted "everyone" (that we know of at least) would move in that direction. The one who I'm thinking may depend on this package is uPort which is why I want to make sure they have someone aware of this.

kdenhartog avatar Apr 17 '20 15:04 kdenhartog

Thank you for your reply. I will add a commit to resolve the conflicts.

kg0r0 avatar Apr 17 '20 16:04 kg0r0

@awoie who's the best one at uPort to look at this and make sure it won't break anything for you guys?

From our end @mirceanis will be mostly involved in everything that is related to the DIDComm implementation. We should be fine with this PR but let's discuss on the next DID Auth Call.

awoie avatar Apr 17 '20 16:04 awoie

@awoie @kdenhartog Hi! What is the status of the confirmation?

kg0r0 avatar May 07 '21 19:05 kg0r0