zero-ui icon indicating copy to clipboard operation
zero-ui copied to clipboard

bug: zerotier 1.12.0 compatibility

Open mvivaldi opened this issue 2 years ago • 32 comments

Bug Report

ZeroUI version:

zero-ui:1.5.1

Current behavior:

with the new version of zerotier 1.12.0 I'm unable to:

  • see the member of any networks
  • rename a new network (or make any other modification)

Steps to reproduce:

install the new version of zerotier, login in zeroUI and look at the list of memebers of any network it will display something like:

No devices have joined this network. Use the app on your devices to join aaaaabbbbbcccccddddd1111.

mvivaldi avatar Aug 25 '23 07:08 mvivaldi

I have the same problem. Yesterday my zerotier server received the update, we migrated from ZT 1.10.6 to 1.12.0 and now I'm unable to see the clients on the web interface.

marcomazzaglia avatar Aug 25 '23 09:08 marcomazzaglia

Thanks for reporting the problem. Seems to be ZeroTier Team made some breaking changes to the controller behavior. You should stay on the latest supported ZeroTier version for the controller - 1.10

dec0dOS avatar Aug 25 '23 16:08 dec0dOS

The issue on ZeroTierOne repo to track the problem: https://github.com/zerotier/ZeroTierOne/issues/2108

dec0dOS avatar Aug 25 '23 16:08 dec0dOS

          Fixed in 1.12.1

Originally posted by @glimberg in https://github.com/zerotier/ZeroTierOne/issues/2108#issuecomment-1694020567

dec0dOS avatar Aug 26 '23 00:08 dec0dOS

Everything I have has been upgraded to 1.12.1, systems rebooted, and I'm still not seeing them in ZeroUI.

Looks like others are still having the same issue, from the main ZeroTierOne Github issues list:

https://github.com/zerotier/ZeroTierOne/issues/2114

iball avatar Aug 26 '23 21:08 iball

Already fixed via my commit https://github.com/dec0dOS/zero-ui/commit/856682bad1ccd46970681e45bea8a992043c38f4

wongsyrone avatar Aug 27 '23 12:08 wongsyrone

https://github.com/zerotier/ZeroTierOne/issues/2114

eduardo010174 avatar Aug 28 '23 09:08 eduardo010174

Already fixed via my commit 856682b

Is it included in current version of zero-ui?

U11Leung avatar Aug 28 '23 13:08 U11Leung

It was fixed in https://github.com/zerotier/ZeroTierOne/pull/2115, waiting for 1.12.2 release

dec0dOS avatar Sep 01 '23 00:09 dec0dOS

It was fixed in zerotier/ZeroTierOne#2115, waiting for 1.12.2 release

Perfect! Do you know the time when 1.12.2 will be released?

marcomazzaglia avatar Sep 06 '23 15:09 marcomazzaglia

Everything I have has been upgraded to 1.12.1, systems rebooted, and I'm still not seeing them in ZeroUI.

Looks like others are still having the same issue, from the main ZeroTierOne Github issues list:

zerotier/ZeroTierOne#2114

@iball Have you found a fix for it?

KevinRoebert avatar Sep 14 '23 12:09 KevinRoebert

@KevinRoebert you should wait for 1.12.2 release or downgrade ZeroTier on the controller to supported version.

dec0dOS avatar Sep 14 '23 12:09 dec0dOS

1.12.2 is now released

glimberg avatar Sep 14 '23 21:09 glimberg

Upgraded all my clients to 1.12.2 to include the server running ZeroUI and it's still not showing any clients/peers. zerotier-cli peers lists them all just fine but it's not showing up in the ZeroUI web UI.

iball avatar Sep 14 '23 22:09 iball

Someone can confirm this? before I can give 1.12.2 a try

U11Leung avatar Sep 19 '23 15:09 U11Leung

1.12.2 Still having problems

canghaiwuhen avatar Sep 20 '23 01:09 canghaiwuhen

let's reopen one on their issue list

U11Leung avatar Sep 20 '23 08:09 U11Leung

Yep broken with ZT 1.12.2, I am seeing no clients.

knightian avatar Oct 01 '23 09:10 knightian

Same issue for me on fedora, I reverted to zerotier 1.10.2 and that solved the issue

jonaavanza avatar Oct 03 '23 23:10 jonaavanza

You basically need to revert one line in backend/routes/member.js to get rid of the compatibility fix introduced to handle 1.12.0, now that the compatibility is back to what it was before.

See https://github.com/dec0dOS/zero-ui/commit/856682bad1ccd46970681e45bea8a992043c38f4#r126131655

Mihara avatar Oct 04 '23 07:10 Mihara

You basically need to revert one line in backend/routes/member.js to get rid of the compatibility fix introduced to handle 1.12.0, now that the compatibility is back to what it was before.

See 856682b#r126131655

Please keep in mind that the controller API responses for version 1.12.2 are still distinct from those in version 1.10. This commit was initially introduced as a temporary solution for the 1.12.0 release within the main branch, but the new ZeroUI version hasn't been released yet. I'm planning to revert it back while we await a proper fix from the ZeroTier team. For now, the best solution is to use the 1.10 ZeroTier version on the controller.

dec0dOS avatar Oct 04 '23 13:10 dec0dOS

Please keep in mind that the controller API responses for version 1.12.2 are still distinct from those in version 1.10

If this is still the case after 1.12.2, it hasn't been reported to us at ZeroTier.

glimberg avatar Oct 04 '23 13:10 glimberg

I couldn't replicate the issue with 1.12.2. My apologies, it turns out I was actually testing 1.12.1 at the time. Could someone please verify the problem with their setup using ZeroUI version 1.5.1 and ZeroTier 1.12.2? If you're still experiencing the problem, please consider building from the source and report any issues.

dec0dOS avatar Oct 04 '23 15:10 dec0dOS

With the latest update 1.5.8 everything is working fine!

Thank you

mvivaldi avatar Oct 05 '23 07:10 mvivaldi

@dec0dOS I built your latest commit from source and it is working. One thing to note for everyone, is it seems that with 1.12 zerotier is changing permissions of authtoken.secret to be 600 (rw- --- ---) and owned by root, so because I am spawning zeroui as a user that is not root, it can't access the authtoken.secret file. If I allow that user access to the authtoken, on restart zerotier changes the permissions back. Worth noting this.

knightian avatar Oct 05 '23 07:10 knightian

@dec0dOS I built your latest commit from source and it is working. One thing to note for everyone, is it seems that with 1.12 zerotier is changing permissions of authtoken.secret to be 600 (rw- --- ---) and owned by root, so because I am spawning zeroui as a user that is not root, it can't access the authtoken.secret file. If I allow that user access to the authtoken, on restart zerotier changes the permissions back. Worth noting this.

In that case you should probably set ZU_CONTROLLER_TOKEN in env.

dec0dOS avatar Oct 05 '23 15:10 dec0dOS

After pulling the latest docker image, it's working properly now. Thank you.

iball avatar Oct 06 '23 00:10 iball

@dec0dOS I built your latest commit from source and it is working. One thing to note for everyone, is it seems that with 1.12 zerotier is changing permissions of authtoken.secret to be 600 (rw- --- ---) and owned by root, so because I am spawning zeroui as a user that is not root, it can't access the authtoken.secret file. If I allow that user access to the authtoken, on restart zerotier changes the permissions back. Worth noting this.

In that case you should probably set ZU_CONTROLLER_TOKEN in env.

Great! I was wondering if this was a thing. Thanks

knightian avatar Oct 06 '23 01:10 knightian

Flow rules still not work.

eduardo010174 avatar Oct 06 '23 10:10 eduardo010174

@eduardo010174, please provide minimal, reproducible example.

dec0dOS avatar Oct 08 '23 13:10 dec0dOS