prometheus.ex icon indicating copy to clipboard operation
prometheus.ex copied to clipboard

Prometheus.Erlang: Fix Kernel.Utils.defdelegate usage for Elixir 1.14

Open lanodan opened this issue 3 years ago • 4 comments

Elixir 1.14 changed Kernel.Utils.defdelegate/2 into Kernel.Utils.defdelegate_each/2

lanodan avatar Aug 02 '22 08:08 lanodan

Elixir v1.14 is officially released yesterday 🎉

This change would be way much more appreciate now 🙏🏽

ulissesalmeida avatar Sep 02 '22 09:09 ulissesalmeida

Can this be merged? Would be great, thanks!

pierot avatar Oct 14 '22 14:10 pierot

I don't know if it helps, but we're using this commit in production for several weeks, all good 👍🏽

ulissesalmeida avatar Oct 14 '22 18:10 ulissesalmeida

Branch works for me as well and also hoping this can be merged, Thank you!

jrichocean avatar Oct 18 '22 20:10 jrichocean

Really interested in this too. By, chance do you have some estimation to merge and release it? Also if there's something that I can help with, just let me know.

gabrielpedepera avatar Oct 21 '22 08:10 gabrielpedepera

Can I please not have yet another "Works For Me"?
It's nice to know but I think that point has been well proven by now.

lanodan avatar Oct 21 '22 09:10 lanodan

Could this PR be merged and released in a new version, please?

alexandresw avatar Nov 25 '22 13:11 alexandresw

Any news on this one? @deadtrickster maybe? Thx!

imsoulfly avatar Jan 16 '23 12:01 imsoulfly

@deadtrickster Hi! This PR is ready to merge. We've waited for prometheus.ex to support the newest Elixir because monitoring is the most important part of our operation on the Elixir application in production. 🙏 🙏 🙏

mopp avatar Feb 14 '23 06:02 mopp

Still not merged, fr :/

dustinrouillard avatar Mar 09 '23 21:03 dustinrouillard

I don't need this anymore - I've migrated to telemetry and telemetry_metrics_prometheus_core.

Stratus3D avatar Mar 09 '23 21:03 Stratus3D

@deadtrickster ping 🙏 🙏 🙏

mopp avatar Mar 29 '23 01:03 mopp

@deadtrickster @ikvmw please merge 🙏 🙏 🙏 🙏 🙏 🙏 🙏

mopp avatar Jun 01 '23 02:06 mopp

Elixir v1.15 is officially released yesterday 🎉

mopp avatar Jun 20 '23 00:06 mopp

@deadtrickster or @ikvmw Any update here?

gerbal avatar Jul 04 '23 18:07 gerbal

@deadtrickster We are waiting to merge 😭 😭 😭

mopp avatar Jul 27 '23 02:07 mopp

Bump on this, would be great to merge... :pray:

sorliem avatar Oct 10 '23 19:10 sorliem

just to add more nagging, can this be merge? the community is going to hurt unless we start forking (which is not really a good place to be either) @deadtrickster please? can you help? who else is a project owner here?

epinault avatar Nov 16 '23 21:11 epinault

for those who need, I updated also the deps and merge the fix here for now https://github.com/podium/prometheus.ex as another option

epinault avatar Nov 16 '23 22:11 epinault

Sorry, I forgot 🤷‍♂️

deadtrickster avatar Nov 16 '23 22:11 deadtrickster

published package as well

deadtrickster avatar Nov 16 '23 22:11 deadtrickster

Thanks @deadtrickster !

sorliem avatar Nov 16 '23 22:11 sorliem

thanks! @deadtrickster

epinault avatar Nov 16 '23 23:11 epinault

Thanks @deadtrickster !

mopp avatar Nov 17 '23 00:11 mopp

Thank you @deadtrickster

ulissesalmeida avatar Nov 17 '23 12:11 ulissesalmeida

:blush:

ikavgo avatar Nov 17 '23 14:11 ikavgo