foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Doesn't follow forks?

Open haydenflinner opened this issue 7 years ago • 5 comments

I have a procfile that looks like this:

controller: ./gtcontroller
store1: sleep 1; ./gtstore -p $PORT
store2: sleep 1; ./gtstore -p $PORT
client: sleep 2; ./gtclient

When I run it with Foreman, the gtstores are still visible with pgrep store, and their pids are a little bit higher than the PIDs that Foreman claims to have seen.

When I run the same procfile with honcho, everything works fine; the processes are killed at the end as expected.

haydenflinner avatar Apr 21 '18 13:04 haydenflinner

@haydenflinner is this still an issue?

andrewmcodes avatar Mar 18 '19 22:03 andrewmcodes

Well, did you do anything that would have fixed it? I don't see anything in the commit history since I posted it that would have helped. Although in hindsight one workaround is

store1: bash -c "sleep 1; ./gtstore -p $PORT"

haydenflinner avatar Mar 19 '19 01:03 haydenflinner

I’m just trying to help out the maintainer by doing some issue triage 🙂

andrewmcodes avatar Mar 21 '19 04:03 andrewmcodes

Maybe due to https://github.com/ddollar/foreman/issues/779? That issue has been addressed in overman, a foreman fork, see https://github.com/ddollar/foreman/pull/780#issuecomment-1294980165

dentarg avatar Oct 28 '22 16:10 dentarg

This would probably be the perfect fix. Running in separate process group and killing that is perfect. I forgot about this tool but may need it again in the near future, I'll use your fork if so, that is the proper way to do it!

haydenflinner avatar Oct 28 '22 17:10 haydenflinner