ddnet icon indicating copy to clipboard operation
ddnet copied to clipboard

Disable Dummy on Solo Maps

Open teini94 opened this issue 3 years ago • 12 comments

add it to sv_solo_server 1 to prevent multiple finishes we cant just players_per_ip 1 cause of timeout

teini94 avatar Aug 02 '22 20:08 teini94

What's wrong with having both you and your dummy play the map at the same time?

VoxelDoesCode avatar Aug 02 '22 20:08 VoxelDoesCode

players_per_ip 1 is no solution, since that would prevent that two persons in the same room playing the same solo map. Also I do not see a problem with having the dummy finish at the same time, because you used all the time dummy copy.

C0D3D3V avatar Aug 02 '22 21:08 C0D3D3V

It's annoying because it moves everyone else one rank down further. But we can't prevent it easily.

def- avatar Aug 02 '22 21:08 def-

we could even disable connecting dummys in ictf server

teini94 avatar Aug 02 '22 21:08 teini94

Server flags are send to the player when they connect if I remember correctly, so you can disable the dummy flag when the map reloads. There is probably a way to still get around it since it's purely a UI change as far as I know but it helps a lot of cases since most people won't go through the effort.

JSaurusRex avatar Aug 02 '22 21:08 JSaurusRex

https://github.com/ddnet/ddnet/pull/4358

fokkonaut avatar Aug 03 '22 04:08 fokkonaut

It also gives an "unfair" advantage where someone can try faily part twice by disabling dummy_copy just before the hard part.

Chairn avatar Aug 03 '22 19:08 Chairn

I guess for testing hard parts you would just put your dummy in a perma practice team and tp it any time to you... You do not need dummy_copy (but on solo maps there is no perma practice team so maybe you save a little time with dummy_copy). Thats what player actually do on faily maps, with very faily parts. I have seen that multiple times. Since this is in theory also possible with an second client, I do not see this as a problem. I only see the problem def- has mentioned.

C0D3D3V avatar Aug 03 '22 22:08 C0D3D3V

After you trained the part, you still use dummy_copy to have 2 chances of trying a legit run, so it still gives unfair advantage.

Chairn avatar Aug 03 '22 23:08 Chairn

True, I think allowing to set the SERVERCAPFLAG_ALLOWDUMMY via map setting or generally for solo maps, would be ok.

C0D3D3V avatar Aug 03 '22 23:08 C0D3D3V

SERVERCAPFLAG_ALLOWDUMMY is a general flag for the server, it can't be changed on map change. We'd have to come up with a different message for it.

heinrich5991 avatar Aug 05 '22 13:08 heinrich5991

I had it implemented as a GameInfoFlag first, but your opinion was it belongs to the Servercap flags :D What a pity :/

fokkonaut avatar Aug 05 '22 16:08 fokkonaut