serial-rs icon indicating copy to clipboard operation
serial-rs copied to clipboard

Published 20 hours ago • verified publisher icon dcuddeback

Use `Option<Duration>` for timeouts.

Open reitermarkus opened this issue 6 years ago • 5 comments

A timeout of None means that operations will block indefinitely. This is similar to what std::net::TcpStream does.

reitermarkus avatar Dec 24 '18 21:12 reitermarkus

@dcuddeback, ping.

reitermarkus avatar Dec 31 '18 07:12 reitermarkus

@dcuddeback, ping.

reitermarkus avatar Jan 10 '19 19:01 reitermarkus

@dcuddeback, ping.

Please don't do that. I'm busy, and there's no reason your PR should receive priority over anything else on my agenda.

dcuddeback avatar Jan 10 '19 19:01 dcuddeback

@dcuddeback, please forgive me for being a nag. I don't want preferential treatment, I just hate PRs going stale. I can understand you're busy, I'd volunteer as a collaborator on this project if you'd like, to take some workload off of you.

reitermarkus avatar Jan 10 '19 19:01 reitermarkus

Into<Option<Duration>> might be better, because then callers can still just pass a Duration if they want a timeout. See eg. Calloop's run() method.

detly avatar Jul 08 '21 05:07 detly