David Coles

Results 48 comments of David Coles

Just to add a little more context (@JarvisCraft beat me to the reply): The reason that there's no [`furi_check`](https://sourcegraph.com/github.com/flipperdevices/flipperzero-firmware@022fccf0d79bb2c3b68e5d55d12f67c073ad7f32/-/blob/furi/core/check.h?L76:9-76:19) is because it is a macro, which bindgen isn't able to...

Having a Furi specific `Duration`/`Instant` type that works on ticks seems to be quite useful, especially for some of the more low-level APIs. I wonder if we want to rename...

I agree something like `main(args: *mut u8)` should be marked `unsafe` since it has the prerequisite that `args` contains NUL-terminated bytes. It's also not something that user programs should typically...

So far this is looking great. I think everyone will appreciate not having to use `sys` to put something on the screen. One issue I did run into in the...

> As for now, I think about one way to implement this: theoretically, we could provide dispatcher-functions matching the C-signature and pass the actual closures via context. The dispatcher-function would...

> Hi, @dcoles! Since you've added `gui` as an explicit module ni your recent commits, should I migrate current code to it? Yes please. I'm trying to roughly maintain the...

> As a small status update on this PR: I'm out for my holidays thus I'm taking some rest from development (also, I don't have my flipper with me for...

Hi @tocklime, > I think this is doable using the trick detailed [here ('improving ergonomics' section)](https://users.rust-lang.org/t/callback-based-c-ffi/26583/5) - I haven't tested this much, and I'm sure it's not sound, but something...

Hey @JarvisCraft. Sorry for the delay in responding. I'm traveling at the moment, so I've been limited on time in front of a computer. I think this is a good...

Absolutely agree. When implementing the current `storage_cli` code in `tools/`, I tried to keep it identical to the Python implementation because of just how fragile that kind of CLI driving...