David Taylor

Results 67 issues of David Taylor

When a query parameter includes `%26`, `normalized_encode` replaces it with a literal `&`, which results in a different URI: ```ruby pry(main)> Addressable::URI.normalized_encode("https://example.com?foo=bar%26baz") => "https://example.com?foo=bar&baz" ``` The more comprehensive `URI#normalize` method...

Accepted
Duplicate

This is a little more complex because we were using the JQuery selector filter so that the callback only ran for events bubbled from `a` elements. This commit re-implements that...

This library attempts to find dependencies using a regular expression: https://github.com/borisirota/webworkify-webpack/blob/2e7827dc8e88a4eb45055d0cc7a0597de0d4fd99/index.js#L97-L103 In minified code, `webpackRequireName` will often be a single-character function name like `r`, so this regex will detect all...

(Test for https://github.com/discourse/.github/pull/48)

Given a valid URL like `https://example.com/article/id%3A1.2%2F1/bar`, addressable's normalization replaces `%3A` with a literal `:`, and `%2F` with a literal `/`. Both of these replacements change the URL, meaning that requests...

Accepted
Duplicate

PluginConnector remains a Classic Component, so this commit does not require any changes from plugin/theme developers. Two shims are introduced for backwards compatibility: - The `component` variable passed to `shouldRender`...

Previously, cancelling a job would `splice` it from the queue. This was problematic because it affects the index of all later jobs in the queue. The `targetQueues` map of jobs...

https://developer.chrome.com/blog/devtools-modern-web-debugging/#linked-stack-traces This enables the Chrome developer tools to link the stack traces of the original event scheduling and the eventual execution on the runloop. This is available in Chrome 106...

To view, run `yarn ember server` and then visit `localhost:4200/bench` in a browser. Running under `node` is still supported.