davidpolverari

Results 25 comments of davidpolverari

PS: On this implementation, I had to use the `// fall through` comment in order to placate GCC's `-Wimplicit-fallthrough`, as the project Makefile WARN_CFLAGS are considering a lot of warnings...

Thanks for the review! I will try to address the points you made as soon as I can.

> * have you thought about using `mmap`? that could simplify the design. About this point, I was thinking about using `mmap`, but using it precludes the use of `strtok*`,...

I sent a new commit for the current PR. As soon as the code is ready for merging, I'll rebase everything.

I already addressed most of the points you made on my local repo. As soon as I implement the remaining ones (`netrc_t`, `strspn`-like interace, and `--no-netrc`) I will send the...

I didn't forget about this issue. I was busy because of work, but will resume as soon as possible.

I just sent another WIP commit with most of the proposed changes, including using `strspn` and `strcspn`-like functions (which I named `memspn` and `memcspn` as they don't deal with null-terminated...

I believe that with those latest PRs most of the requested things were changed. I have doubts now as to where we should keep the `netrc_t` pointer, at what point...

Well, with this last PR I think the changes are almost all done, the only missing piece being the negative option (and removing the debugging `printf` I put). There are...

> Looks much better now. I made a couple of comments, the only important task now is to complete the get_creds implementation. What else do you think it is missing...