tracing-tree

tracing-tree copied to clipboard

When opening a span with no fields, there's a trailing space on the line. I believe [this line](https://github.com/davidbarsky/tracing-tree/blob/ca5ec3aba763e60d8cd2cf9ee83a19770d81c59d/src/lib.rs#L383) could be changed to `} else if !self.kvs.is_empty() {` to correct this.

Kyuuhachi

They don't actually make it more readable imo and they block editors from folding scopes

oli-obk

Or, to be honest, this needs to be a trait like `FormatTime` already is, with an option to disable.

Earthcomputer

Allow time formatting of events through `time::formatting::Formattable`

1

The current implementation of event time formatting only allows for the default date time formatting `2023-10-11 13:57:26.676558 +02:00:00` which can be very verbose and creates long lines in the terminal...

ten3roberts

verbose_exit(false) and verbose_entry(true): ```sh 1:main┐basic::hierarchical-example version=0.1 1:main│└┐basic::server host="localhost", port=8080 1:main│ ├─ 0ms INFO basic starting 1:main│ ├─ 3s INFO basic listening 1:main│ │└┐basic::conn peer_addr="82.9.9.9", port=42381 1:main│ │ ├─ 0ms DEBUG...

ten3roberts

Put fields on their own lines

2

I'm opening this to discuss how it looks and whether we want something like this. I'd prefer not to make it configurable, but just turn it on by default. I'll...

oli-obk

Logging prefixed with `thread_id:thread_name` is missing a space

1

Originally reported in https://github.com/rust-lang/rust/issues/78931. ``` 2:rustc INFO rustc_interface::passes Pre-codegen 2:rustcTy interner total ty lt ct all 2:rustc Adt : 1078 81.3%, 0.0% 0.0% 0.0% 0.0% 2:rustc Array : 1 0.1%,...

jyn514

Make ansi colors compile time feature

2

I've noticed that we always configure tracing tree with `with_ansi(false)` in rust-analyzer, so I think we can shave a couple of dependencies off here!

matklad

Better indicate which log entries are repeated

8

(I am not a direct user of this crate but involved via reviewing https://github.com/rust-lang/rust/pull/75143, which will make Miri use this crate) @oli-obk pointed me to [this example](https://github.com/davidbarsky/tracing-tree/blob/5977c7ff25be17b96fe5d731f994114558a085bc/examples/basic.stdout) of how the...

RalfJung

Print the duration of the span when closing a span

2

> * I'd like to be able to visually distinguish between a span that has _exited_ and a span that has _closed_. That could be done with durations, but that's...

oli-obk