David Sancho

Results 138 comments of David Sancho

I wonder if you can add the test case for a fragment (which is a list on the parsetree) which avoids the wrapping. ``` {React.string("HI")} {React.string("HI")} ```

This will force all usages of children to be either fragments, or wrapped in React.array.

- 1 and 2 are done. reason-react 0.11 and 0.12 have this `{>= "3.6.0" & < "3.10.0"}` Would you add a conflict on reactjs-jsx-ppx?

I we don't mention reactjs-jsx-ppx I don't think people will face the issue also

I believe this is a bug in our code, right? An array of elements where some of them are null seems a bad JSX construction. I have coded myself worst...

> There were also 10+ places where keys were added unnecessarily That's very suspicious, people rarely add keys without a good reason.

Hi @pkoppstein `.[]` is equivalent as `. | .map` so probably doable with a workaround. If `.[]` isn't working as expected, can you give me an example? If it doesn't...

I have vendored this project under server-reason-react on https://github.com/ml-in-barcelona/server-reason-react/tree/main/packages/promise, and changes that I made was: - Add dune file for js/ - Remove `type Result` and result dependency on native/...

Thanks for opening the issue @mlawrence999 and sorry for the late response. As you can see, node-jq doesn't depend on `bin-build` at runtime, so this security vulnerability doesn't happen if...

We don't provide this flag on node-jq currently. Feel free to push a PR with this!