learningpath-docker

learningpath-docker copied to clipboard

Please review my Week II assignment!

My name: Renato Ivancic My GitHub repository: https://github.com/rivancic/docker-example/tree/master/docker-compose-week-2 Description: I will use my hobby project that is otherwise deployed in AWS environment and accessible on ITShelf.com.

Docker Compose will spin up 2 Docker containers. First one contains Spring Boot web application that renders pages with Thymeleaf templating engine. Second container includes Postgres database with basic envent information that will be rendered within first application. More description is in the repository itself.

BTW @HadesArchitect, feel free to pick this assignment apart and roast it tomorrow in webinar.

• nice use of volumes for database: creation script and persistence files
• it's good that environment variables are used for configurable properties (database related in this case). As an improvement, if this was a production-ready project, sensitive environment variables like the DB password would be stored in an enviroment file which would not be stored in source control
• If the source code is in another repository, I would add a step in the docker file for downloading the jar for a maven repository or something similar instead of keeping the jar in github. The jar version can also be an environment variable