dbx icon indicating copy to clipboard operation
dbx copied to clipboard

Pass jobs_api_version to ApiClient constructor

Open aholten opened this issue 3 years ago • 1 comments

Pass the jobs_api_version to the ApiClient so that jobs API endpoint urls use the appropriate Jobs API version (instead of defaulting to 2.0)

Enables use of Databricks Jobs API 2.1 in dbx

Proposed changes

Resolves issue Jobs 2.1 API setting ignored by DatabricksClientProvider #378

Types of changes

What types of changes does your code introduce to dbx? Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Further comments

n/a

aholten avatar Aug 10 '22 01:08 aholten

This pull request introduces 1 alert when merging 1638938c05ec557704eb7ed03c4090588075452f into f3fc016f944a2a23f2f6bc960c6147ecd60ec12b - view on LGTM.com

new alerts:

  • 1 for Syntax error

lgtm-com[bot] avatar Aug 10 '22 02:08 lgtm-com[bot]

Comma added, changelog updated- thank you!

aholten avatar Aug 10 '22 13:08 aholten

I'll merge this pr, but it seems a pretty small change for a full-scale release. As of now please use this env variable: export DATABRICKS_JOBS_API_VERSION=2.1

To fix this property.

renardeinside avatar Aug 10 '22 13:08 renardeinside

Codecov Report

Merging #379 (93fda58) into main (f3fc016) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files          38       38           
  Lines        2172     2172           
  Branches      379      379           
=======================================
  Hits         1924     1924           
  Misses        183      183           
  Partials       65       65           
Impacted Files Coverage Δ
dbx/api/client_provider.py 71.11% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 13:08 codecov[bot]