dbx icon indicating copy to clipboard operation
dbx copied to clipboard

`dbx sync` doesn't convert line endings when syncing to repo

Open jiri-vinarek opened this issue 3 years ago • 1 comments

Expected Behavior

I expect dbx sync to convert line endings in order to see only the actual changes made in the repository in the Databricks Repo client.

Current Behavior

When running dbx sync repo -d ourproject from Windows dbx will copy the local files to the Repo and these files will appear as changed although the only difference is the line endings.

Context

Our project uses automatic handling of line endings (core.autocrlf true). Therefore, a user with Windows will have their local copy with files using CRLF as a line ending. Repo added on the Databricks side will use CR as a line ending as it runs on Linux.

A workaround is to convert our whole repository to use CR line endings. But as our developers use mainly macOS and Windows, we would prefer our current settings.

Your Environment

  • dbx version used: 0.6.3
  • Databricks Runtime verson: 10.4

jiri-vinarek avatar Jul 06 '22 12:07 jiri-vinarek

@matthayes could you please take a look into this?

renardeinside avatar Jul 07 '22 08:07 renardeinside