databricks-sdk-go icon indicating copy to clipboard operation
databricks-sdk-go copied to clipboard

Published 20 hours ago • verified publisher icon databricks

Trim method path parameters of leading slashes

Open nfx opened this issue 1 year ago • 1 comments

Changes

Fundamentally prevent regressions like

PUT /api/2.0/fs/files//Volumes/main/x/y/z
> [non-JSON document of 11 bytes]. <io.Reader>
< HTTP/2.0 400 Bad Request
< {
<   "error_code": "BAD_REQUEST",
<   "message": "Invalid path"
< }

nfx avatar Nov 27 '23 09:11 nfx

Codecov Report

Attention: 238 lines in your changes are missing coverage. Please review.

Comparison is base (af0eafe) 16.34% compared to head (3465497) 16.34%.

Files Patch % Lines
service/catalog/impl.go 0.00% 66 Missing :warning:
service/iam/impl.go 0.00% 32 Missing :warning:
service/sql/impl.go 0.00% 29 Missing :warning:
service/sharing/impl.go 0.00% 19 Missing :warning:
service/compute/impl.go 0.00% 16 Missing :warning:
service/provisioning/impl.go 0.00% 16 Missing :warning:
service/settings/impl.go 0.00% 16 Missing :warning:
service/workspace/impl.go 0.00% 14 Missing :warning:
service/pipelines/impl.go 0.00% 13 Missing :warning:
service/ml/impl.go 0.00% 8 Missing :warning:
... and 2 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   16.34%   16.34%           
=======================================
  Files          98       98           
  Lines       13996    13996           
=======================================
  Hits         2287     2287           
  Misses      11518    11518           
  Partials      191      191

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 27 '23 09:11 codecov-commenter