cli

cli copied to clipboard

Changes

This adds a top-level IS_OWNER permission to help with collaborative deployment scenarios:

• IS_OWNER is now accepted at the top level
• Templates now include a top-level owner
• Validation for mode: production now accepts a top-level owner as an alternative to a run_as identity.

Tests

Unit tests, manual experimentation.

Apr 22 '24 07:04 lennartkats-db

Codecov Report

Attention: Patch coverage is 98.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.63%. Comparing base (e22dd8a) to head (e4df0b9). Report is 125 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
+ Coverage   52.25%   53.63%   +1.37%     
==========================================
  Files         317      351      +34     
  Lines       18004    20290    +2286     
==========================================
+ Hits         9408    10882    +1474     
- Misses       7903     8610     +707     
- Partials      693      798     +105     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Apr 22 '24 07:04 codecov-commenter

@pietern could you take another look?

Jul 11 '24 13:07 lennartkats-db

@andrewnester Could you take a look as well?

Jul 15 '24 08:07 pietern

Let's have another brief live discussion about this before merging it @pietern

Aug 06 '24 07:08 lennartkats-db

As discussed, we're going to take this work in a different direction. Closing this for now.

Aug 22 '24 19:08 lennartkats-db