cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon databricks

Support Lakehouse monitoring in bundles

Open aravind-segu opened this issue 1 year ago • 3 comments

Changes

Support Lakehouse Monitoring in Bundles

Testing

Unit Tests

aravind-segu avatar Mar 24 '24 18:03 aravind-segu

Regarding the hacky approach This looks pretty hacky. Can't we use the url tag of the field?. The url field is empty as well. CreateMonitor takes in the table name as part of the query parameters and it is not passed in json body.

aravind-segu avatar Apr 15 '24 16:04 aravind-segu

Tests are failing because of the change to not avoid json - parameters in struct_info. How can we solve this? Is it ok to modify the tests?

aravind-segu avatar Apr 22 '24 20:04 aravind-segu

Codecov Report

Attention: Patch coverage is 51.25000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 53.58%. Comparing base (e22dd8a) to head (a2384c1). Report is 124 commits behind head on main.

Files Patch % Lines
bundle/config/resources.go 0.00% 15 Missing and 3 partials :warning:
libs/dyn/convert/struct_info.go 0.00% 6 Missing and 1 partial :warning:
bundle/deploy/terraform/convert.go 70.00% 5 Missing and 1 partial :warning:
.../deploy/terraform/tfdyn/convert_quality_monitor.go 64.70% 4 Missing and 2 partials :warning:
bundle/deploy/terraform/interpolate.go 0.00% 2 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   52.25%   53.58%   +1.33%     
==========================================
  Files         317      351      +34     
  Lines       18004    20268    +2264     
==========================================
+ Hits         9408    10861    +1453     
- Misses       7903     8609     +706     
- Partials      693      798     +105

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 06 '24 03:05 codecov-commenter

The TF bump is happening in #1460.

pietern avatar May 31 '24 06:05 pietern